Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add golangci lint #100

Merged
merged 3 commits into from
Nov 16, 2020
Merged

Add golangci lint #100

merged 3 commits into from
Nov 16, 2020

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Nov 15, 2020

What type of PR is this?
/kind cleanup
/kind feature

Any specific area of the project related to this PR?
/area build

What this PR does / why we need it:
Add golangci-lint to the project, fix lints and add check lint to the circleci

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@poiana
Copy link

poiana commented Nov 15, 2020

@cpanato: The label(s) area/build cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?
/kind cleanup
/kind feature

Any specific area of the project related to this PR?
/area build

What this PR does / why we need it:
Add golangci-lint to the project, fix lints and add check lint to the circleci

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato cpanato force-pushed the add-golangci-lint branch 3 times, most recently from aba73c4 to 25e4be6 Compare November 15, 2020 17:21
@cpanato cpanato force-pushed the add-golangci-lint branch 2 times, most recently from 0674457 to 3342c6d Compare November 15, 2020 17:45
Issif
Issif reviewed Nov 15, 2020
View reviewed changes
outputs/smtp_templates.go Outdated Show resolved Hide resolved
@leogr
Copy link
Member

leogr commented Nov 16, 2020

/test all

@cpanato
add golangci-lint
1f60214 
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@cpanato
Fix lints
abd5193 
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@cpanato
Add check lint to circleci and remove the tag filter
9283d8c 
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@cpanato cpanato requested a review from Issif November 16, 2020 12:30
@poiana poiana added the lgtm label Nov 16, 2020
@poiana
Copy link

poiana commented Nov 16, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Nov 16, 2020

LGTM label has been added.

Git tree hash: 8ab61ad20129f787575ca9f9fedef2d5d67c6999

@poiana poiana merged commit d6056e6 into falcosecurity:master Nov 16, 2020
@cpanato cpanato deleted the add-golangci-lint branch November 16, 2020 15:05
Kaizhe pushed a commit to Kaizhe/falcosidekick that referenced this pull request Jul 28, 2021
@poiana
Fix broken link to k8s_audit_config
89453f5 
Fixes falcosecurity#100

Signed-off-by: Christian Zunker <christian.zunker@codecentric.cloud>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Issif Issif Issif approved these changes

@nibalizer nibalizer Awaiting requested review from nibalizer

Assignees

@Issif Issif

Labels
approved dco-signoff: yes kind/cleanup kind/feature New feature or request lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cpanato @poiana @leogr @Issif